Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated docs to Korean #2603

Merged
merged 58 commits into from Nov 22, 2018
Merged

Translated docs to Korean #2603

merged 58 commits into from Nov 22, 2018

Conversation

gamjapark
Copy link
Contributor

@gamjapark gamjapark commented Nov 20, 2018

  • docs/root/source/assets.md
  • docs/root/source/bft.md
  • docs/root/source/decentralized.md
  • docs/root/source/diversity.md
  • docs/root/source/imutable.md
  • docs/root/source/index.md
  • docs/root/source/permissions.md
  • docs/root/source/private-data.md
  • docs/root/source/production-ready.md
  • docs/root/source/query.md
  • docs/root/source/smart-contracts.md
  • docs/root/source/store-files.md
  • docs/root/source/terminology.md
  • docs/root/source/transaction-concepts.md

My team translate some docs.
Can you check our work?

gamjapark and others added 30 commits November 14, 2018 10:15
docs/root/source/index_kor.md Outdated Show resolved Hide resolved
@ttmc
Copy link
Contributor

ttmc commented Nov 21, 2018

Now Sphinx is saying:

Warning, treated as error:
/home/travis/build/bigchaindb/bigchaindb/docs/root/source/assets_ko.md:document isn't included in any toctree

That's because none of the new files are included in any "Table of Contents tree" (toctree). That is, none of the new files are listed in an index.rst file. To fix this problem, you could do the following:

  1. Move all the new (Korean) files to a new folder docs/root/source/korean/
  2. Create a new index.rst file in that folder (docs/root/source/korean/index.rst) with a structure similar to docs/root/source/index.rst but in Korean. This would replace docs/root/source/index_kor.md, which could then be deleted. Note that index.rst files never include the filename extensions (.md or .rst).
  3. Link to the new folder index from docs/root/source/index.rst by adding one line to the toctree section:
   ...
   permissions
   private-data
   Data Models <https://docs.bigchaindb.com/projects/server/en/latest/data-models/index.html>
   korean/index

You could also put that new line (korean/index) near the top of the Table of Contents if you like.

@ttmc
Copy link
Contributor

ttmc commented Nov 21, 2018

@gamjapark I see you did task 1. in my last comment, but you didn't do task 2. or task 3. yet. That is why the checks are still failing.

If you like, I could just merge this pull request and then do a quick pull request of my own to fix the remaining issues. Let me know.

@gamjapark
Copy link
Contributor Author

I have resolved all errors!!! Done!!!! 😄
Is there something more to do?

@codecov-io
Copy link

Codecov Report

Merging #2603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2603   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          45       45           
  Lines        2684     2684           
=======================================
  Hits         2512     2512           
  Misses        172      172

@gamjapark
Copy link
Contributor Author

I am sorry for bothering you, again.
I changed the link because i made korean folder. finish...!

@ttmc
Copy link
Contributor

ttmc commented Nov 22, 2018

Hi @gamjapark - I am in Berlin, Germany, so the delays are probably just because we're in different time zones. I see you got all the tests passing and everything looks good. I will merge this pull request now.

@ttmc ttmc merged commit a62cc4e into bigchaindb:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants